Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on pylint numeric disables #31136

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Fail on pylint numeric disables #31136

merged 1 commit into from
Jan 24, 2020

Conversation

scop
Copy link
Member

@scop scop commented Jan 24, 2020

Proposed change

Tiny tweak to make build fail if the cryptic numeric pylint disables are used.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@scop scop requested a review from a team as a code owner January 24, 2020 18:22
@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Jan 24, 2020
@scop scop changed the title Pylint strict informational Fail on pylint numeric disables Jan 24, 2020
@scop
Copy link
Member Author

scop commented Jan 24, 2020

CI failure is unrelated, merging

@scop scop merged commit 9795449 into home-assistant:dev Jan 24, 2020
@scop scop deleted the pylint-strict-informational branch January 24, 2020 21:27
@lock lock bot locked and limited conversation to collaborators Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants