New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize insteon code #31183
Reorganize insteon code #31183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Can be merged when the breaking change paragraph is updated. Please ping me when that is done.
@MartinHjelmare I have added the paragraph to the breaking change section but I am not sure there is anything a user needs to do to cope with that change since I don't believe the attributes are used for anything other than documentation. |
Ok. I added a sentence about automations and scripts where it at least theoretically could be used. |
Let's wait with merging this until the beta for 0.105 is cut later today. Then there's more time for further PRs with breaking changes for this integration this release cycle. |
Breaking change
The Insteon entity device state attributes were changed to conform to naming standards.
Insteon Address
is nowinsteon_address
andInsteon Group
is nowinsteon_group
. Users may need to update automations and scripts that rely on these attributes.Proposed change
Reorganize the
insteon
component code to make future edits easier.Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: