Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protect for unknown state and state attributes in Alexa StateReport #31354

Merged

Conversation

ochlocracy
Copy link
Member

@ochlocracy ochlocracy commented Jan 31, 2020

Proposed change

Fix to protect for unknown state and state attributes in Alexa StateReport

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.
  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (alexa) you are listed as a codeowner for? Thanks!

@ochlocracy ochlocracy changed the title Protect for unknown state and state attributes in Alexa StateReport Fix protect for unknown state and state attributes in Alexa StateReport Jan 31, 2020
@ochlocracy ochlocracy added this to the 0.105.0 milestone Jan 31, 2020
@ochlocracy ochlocracy marked this pull request as ready for review January 31, 2020 19:11
@balloob balloob merged commit fa2e409 into home-assistant:dev Jan 31, 2020
balloob pushed a commit that referenced this pull request Jan 31, 2020
@lock lock bot locked and limited conversation to collaborators Feb 2, 2020
@ochlocracy ochlocracy deleted the alexa-protect-for-unknown-attributes branch February 25, 2020 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.105 beta: Error doing job: Task exception was never retrieved (alexa)
3 participants