-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NSAPI library and add attribute for average trip punctuality #31741
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #31741 +/- ##
==========================================
- Coverage 94.66% 94.65% -0.01%
==========================================
Files 762 762
Lines 55029 55029
==========================================
- Hits 52093 52090 -3
- Misses 2936 2939 +3
Continue to review full report at Codecov.
|
Thanks for the PR, much needed update to fix some problems people have been having! First commit looks good, but I'm not sure the second commit will be accepted (202 files changed…). |
2nd commit is just a merge of dev, so no actual delta. Still getting used to git with upstream repository's I can revert and rebase if that would be preferable :) By the way, nice addition of optional time. Was just about to do that :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✌
Breaking change
Proposed change
Updates the NSAPI to better handle some missing values, and adds the average (3month) punctuality of a the trip to the sensor output if available
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: