Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Plex media_player entity naming #31755

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

jjlawren
Copy link
Contributor

Proposed change

Current naming of Plex media_player entities does not provide enough information, making it difficult to identify them and potentially creating many duplicates. This is especially true for users that share their Plex server.

A user watching through a Plex Web client on Chrome would previously be named media_player.plex_chrome. Additional similar clients would be named media_player.plex_chrome_2, media_player.plex_chrome_3, etc.

This PR:

  1. Inserts the username if it is a shared or managed user.
  2. Adds more detail on the type of client playing.
  3. Conditionally adds more context if a common player is in use (Plex Web for now).

If the above client was playing from a shared account, the new name would now be something like media_player.plex_myfriend_plex_web_chrome_osx.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob merged commit 1b2f4fa into home-assistant:dev Feb 12, 2020
@jjlawren jjlawren deleted the plex_entity_naming branch February 12, 2020 18:13
@lock lock bot locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants