New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide user consumable errors when lock operations fail #31864
Provide user consumable errors when lock operations fail #31864
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #31864 +/- ##
==========================================
+ Coverage 94.68% 94.69% +<.01%
==========================================
Files 763 763
Lines 55192 55192
==========================================
+ Hits 52261 52264 +3
+ Misses 2931 2928 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid mocking our own code, and just patch the device library instead.
Will adjust after #31848 merges as this is likely going to conflict |
6de9066
to
a816fc3
Compare
Here's an example of how we want platforms to be tested: Set up the component and platform with Please make a separate PR where the tests are cleaned up before doing the bigger refactor. |
If you need more inspiration here's a PR where I've cleaned up existing non robust tests: |
Thanks, that is helpful. I'll switch to cleaning up the tests after I finish fixing issue #29980 |
This fixes #26672
Breaking change
Proposed change
Provide user consumable errors when lock operations fail
Example: "Failed to call service lock/lock. Door: The operation failed because the bridge (connect) is offline."
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: