Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove YAML config from Ring integration #32039

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Remove YAML config from Ring integration #32039

merged 1 commit into from
Feb 22, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 20, 2020

Breaking change

All Ring accounts require two-factor authentication. This means that it is no longer possible to configure it via YAML as this cannot support 2FA.

Proposed change

Remove YAML configuration from Ring because it cannot support 2FA.

Docs have already been updated: home-assistant/home-assistant.io#12145

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #32039 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32039      +/-   ##
==========================================
- Coverage   94.71%   94.71%   -0.01%     
==========================================
  Files         766      766              
  Lines       55568    55564       -4     
==========================================
- Hits        52629    52625       -4     
  Misses       2939     2939
Impacted Files Coverage Δ
homeassistant/components/ring/config_flow.py 76.19% <ø> (-2.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a12c4da...8bafa17. Read the comment docs.

@balloob balloob merged commit ced870c into dev Feb 22, 2020
@balloob balloob deleted the remove-ring-yaml branch February 22, 2020 01:36
@lock lock bot locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants