Kodi cleanup and config update #5098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@armills, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @joopert and @persandstrom to be potential reviewers. |
emlove
commented
Dec 29, 2016
| @@ -110,7 +107,7 @@ def _get_players(self): | |||
| return self._server.Player.GetActivePlayers() | |||
| except jsonrpc_requests.jsonrpc.TransportError: | |||
| if self._players is not None: | |||
| _LOGGER.warning('Unable to fetch kodi data') | |||
| _LOGGER.info('Unable to fetch kodi data') | |||
There was a problem hiding this comment.
This is just a personal annoyance of mine. Since it's expected Kodi won't always be active, I don't think it needs to be a warning level log message. This can be reverted if others disagree.
lwis
approved these changes
Jan 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some small cleanup of the Kodi platform. This change means that the
hostconfiguration no longer should includehttp://at the start. Logic is included to strip this for backwards compatibility. This brings Kodi in line with other platform configs and is a prerequisite for future websocket support. This also makes the image url logic simpler.PR in home-assistant.github.io: home-assistant/home-assistant.io#1670