Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay ATTR_MEDIA_POSITION and ATTR_MEDIA_POSITION_UPDATED_AT in universal media_player #5184

Merged

Conversation

michaelarnauts
Copy link
Contributor

Description:
Universal media_player returns ATTR_MEDIA_POSITION and ATTR_MEDIA_POSITION_UPDATED_AT from it's active child now.

Related issue (if applicable): fixes #5060

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

…ITION_UPDATED_AT from it's active child now.
@mention-bot
Copy link

@michaelarnauts, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @rmkraus and @fabaff to be potential reviewers.

@balloob balloob merged commit ba29ba0 into home-assistant:dev Jan 5, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Apr 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal media player doesn't take over the progress of the cast media_player
3 participants