Update vlc.py #5334
Merged
Update vlc.py #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for additional optional configuration arguments: to send to vlc. It is useful for special configurations of VLC. For example, I have two sound cards on my server, so I defined two vlc media players: media_player: - platform: vlc name: speaker_1 arguments: '--alsa-audio-device=hw:1,0' - platform: vlc name: speaker_2 arguments: '--alsa-audio-device=hw:0,0' This way, by specifying the corresponding entity_id, I can send the output to the desired speaker. It is also useful for TTS.
|
@MrMep, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Danielhiversen and @armills to be potential reviewers. |
houndci-bot
reviewed
Jan 14, 2017
| }) | ||
|
|
||
|
|
||
| # pylint: disable=unused-argument | ||
| def setup_platform(hass, config, add_devices, discovery_info=None): | ||
| """Setup the vlc platform.""" | ||
| add_devices([VlcDevice(config.get(CONF_NAME))]) | ||
| add_devices([VlcDevice(config.get(CONF_NAME), config.get(ADDITIONAL_ARGS))]) |
There was a problem hiding this comment.
line too long (80 > 79 characters)
|
Great, thanks |
emlove
reviewed
Jan 14, 2017
| @@ -20,28 +20,31 @@ | |||
|
|
|||
| _LOGGER = logging.getLogger(__name__) | |||
|
|
|||
| ADDITIONAL_ARGS = 'arguments' | |||
There was a problem hiding this comment.
This should be renamed to CONF_ARGUMENTS.
|
Documentation updated, I hope I got it right! |
Added default value for "arguments"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added support for additional optional configuration
arguments:
to send to vlc.
It is useful for special configurations of VLC.
For example, I have two sound cards on my server, so I defined two vlc media players:
This way, by specifying the corresponding entity_id, I can send the output to the desired speaker.
It is also useful for TTS.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#1771
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass