Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue improvements #5474

Merged
merged 3 commits into from
Jan 21, 2017
Merged

Hue improvements #5474

merged 3 commits into from
Jan 21, 2017

Conversation

robbiet480
Copy link
Member

Description:

  • Allow disabling of Hue groups
  • Allow automatic removal of all Hue entities from emulated_hue
  • Don't require a host. Platform will error out if no configuration file is found
  • Provide defaults to voluptuous where possible instead of setting defaults in setup_platform

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

light:
  - platform: hue
    allow_in_emulated_hue: false
    allow_hue_groups: false

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link

@robbiet480, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @maddox and @fabaff to be potential reviewers.

def device_state_attributes(self):
"""Return the device state attributes."""
return {
ATTR_EMULATED_HUE: self.allow_in_emulated_hue,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible to make these two optional when False ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@balloob balloob merged commit 2efd7d4 into home-assistant:dev Jan 21, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Apr 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants