Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change medium state for filtering #5817

Merged
merged 1 commit into from
Feb 9, 2017
Merged

Change medium state for filtering #5817

merged 1 commit into from
Feb 9, 2017

Conversation

Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Feb 9, 2017

Description:
Fixes the filtering for ISY994 fan nodes

Related issue (if applicable): fixes #5779

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@mention-bot
Copy link

@Teagan42, thanks for your PR! By analyzing the history of the files in this pull request, we identified @robbiet480 and @w1ll1am23 to be potential reviewers.

@homeassistant
Copy link
Contributor

Hi @Teagan42,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@balloob
Copy link
Member

balloob commented Feb 9, 2017

Thanks! 🐬

@dethpickle dethpickle mentioned this pull request Feb 10, 2017
8 tasks
@home-assistant home-assistant locked and limited conversation to collaborators May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISY based Fan entities undiscovered as of 0.37.0. Lights on the same module are still there.
4 participants