Upgrade pylint to 1.7.2

[fabaff]

1.7.2

• Changelog: https://github.com/PyCQA/pylint/blob/master/ChangeLog

To-do:

• Don't use len(SEQUENCE) as condition value Don't use len(SEQUENCE) as condition value #7249
• Don't use .keys() Iterating the dictionary directly #7251
• no-else-return
• bad-whitespace (new, apply in dev)
• not-context-manager Add not-context-manager #7523
• arguments-differ
• redefined-argument-from-local
• useless-super-delegation
• consider-using-ternary

[mention-bot]

@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @sdague and @andrey-git to be potential reviewers.

[andrey-git]

The run emits lots of new errors

[balloob]

Yeah that happens each time we do this. So let's see what it found and fix it 👍

[houndci-bot]

unexpected spaces around keyword / parameter equals

[balloob]

When we fix issues, we should fix them in dev and just keep rebasing this branch on it. Since they are new warnings, they shouldn't trigger any warnings when fixed in dev.

[fabaff]

OK.

I was just checking what the implications may be on a couple of files because it will require some time to get rid of all issues.

[fabaff]

When we fix issues, we should fix them in dev and just keep rebasing this branch on it. Since they are new warnings, they shouldn't trigger any warnings when fixed in dev.

I think that this approach will not work for a couple of cases.

• Added new check to detect incorrect usage of len(SEQUENCE) inside test conditions.

Could be fixed in dev.

• Require one space for annotations with type hints, as per PEP 8.

This was introduced by 1.7.0. Would lead to an issue in dev. no-else-return too. There may be more.

[robbiet480]

This is gonna be a big changeset. I started it at #7448.

[robbiet480]

BTW, no-else-return is the worst issue by far but easiest to fix luckily.

[balloob]

It looks like PyLint incorrectly detects locks as not being a context manager:

Context manager 'lock' doesn't implement __enter__ and __exit__. (not-context-manager)

We might want to consider disabling that rule for now.

[balloob]

I rebased this to see remaining errors.

[balloob]

Alright, made progress 👍

For now, I focus on fixing warnings while disabling these extra checks:

  bad-whitespace,
  import-error,
  no-name-in-module,
  too-many-nested-blocks,
  no-member

Which gives us 279 errors left to fix, of which 174 are no-else-return. I am planning on focussing on those first.

[balloob]

100 issues left. It's all arguments-differ, which looks like it is even raised when the names of the parameters differ. Should be fairly straightforward to align those.

End is near 😉 (for phase 1)

[balloob]

What should we do with this PR? I gave it a stab and we got pretty close. If no one is going to pick it up, let's close it?

[OttoWinter]

@balloob If you don't mind, I would be willing to pick this up again. I'm using Python 3.6 on my machine and it's pretty annoying having to constantly switch Python versions just to run pylint... However, I'd then also upgrade pylint to 1.8.1 so that the Unused variable '__class__' bug is fixed as in home-assistant-libs/pychromecast#211.

[balloob]

would be great. we will still run pylint under our lowest supported version in CI