Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

myStrom WiFi bulbs #7161

Merged
merged 4 commits into from
Apr 18, 2017
Merged

myStrom WiFi bulbs #7161

merged 4 commits into from
Apr 18, 2017

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 18, 2017

Description:

Support for myStrom WiFi bulbs.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2454

Example entry for configuration.yaml (if applicable):

light:
  - platform: mystrom
    host: 192.168.0.2
    name: myStrom Bulb
    mac: 5AAC8CA542F3

Checklist:

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@mention-bot
Copy link

@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kylehendricks, @balloob and @robbiet480 to be potential reviewers.

Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a decorator for turn_on, turn_off would be nice instead copy & past of code?

@fabaff
Copy link
Member Author

fabaff commented Apr 18, 2017

I think a decorator for turn_on, turn_off would be nice instead copy & past of code?

Sorry, can you elaborate what you mean, please? Especially about what decorator you are talking about.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐬

@balloob
Copy link
Member

balloob commented Apr 18, 2017

I think that @pvizeli was talking about making your own decorator to catch the exception and print a not online warning. You can do that in a future PR if you want 👍

@balloob balloob merged commit c7a1127 into home-assistant:dev Apr 18, 2017
@fabaff fabaff deleted the light-mystrom branch April 18, 2017 16:37
@fabaff
Copy link
Member Author

fabaff commented Apr 18, 2017

This was just a MVP to have something. myStrom is updating the firmware of the bulbs on a regular base to support new features.

The next step will be to add support for color then effects.

@balloob balloob mentioned this pull request Apr 21, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants