-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
myStrom WiFi bulbs #7161
myStrom WiFi bulbs #7161
Conversation
@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kylehendricks, @balloob and @robbiet480 to be potential reviewers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a decorator for turn_on
, turn_off
would be nice instead copy & past of code?
Sorry, can you elaborate what you mean, please? Especially about what decorator you are talking about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐬
I think that @pvizeli was talking about making your own decorator to catch the exception and print a not online warning. You can do that in a future PR if you want 👍 |
This was just a MVP to have something. myStrom is updating the firmware of the bulbs on a regular base to support new features. The next step will be to add support for color then effects. |
Description:
Support for myStrom WiFi bulbs.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#2454
Example entry for
configuration.yaml
(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
tox
run successfully. Your PR cannot be merged unless tests passREQUIREMENTS
variable ([example][ex-requir]).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.