Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Issue 6749 by updating pylgtv to 0.1.5 #7184

Merged
merged 1 commit into from
Apr 19, 2017
Merged

fixed Issue 6749 by updating pylgtv to 0.1.5 #7184

merged 1 commit into from
Apr 19, 2017

Conversation

hmn
Copy link
Contributor

@hmn hmn commented Apr 19, 2017

Description:

updated pylgtv module to 0.1.5 where async timeout error was fixed

it caused the function to not adhere to timeouts and would hang for 75sec when the tv was off, and that would over time cause a lot of open processes because home assistant expected it to timeout correctly after 10 sec

Related issue (if applicable): fixes #6749

Example entry for configuration.yaml (if applicable):

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@homeassistant
Copy link
Contributor

Hi @hmn,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@mention-bot
Copy link

@hmn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wardcraigj, @nugget and @armills to be potential reviewers.

Copy link
Contributor

@patrickeasters patrickeasters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I've been looking forward to this being fixed. And it's using PyPi. 🥇

@emlove emlove merged commit b985e4e into home-assistant:dev Apr 19, 2017
@emlove
Copy link
Contributor

emlove commented Apr 19, 2017

Thanks for the contribution! 🎉

@balloob balloob mentioned this pull request Apr 21, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Aug 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webostv keeps files open until file limit is reached
6 participants