Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent notification import #8507

Merged
merged 3 commits into from
Jul 16, 2017
Merged

Persistent notification import #8507

merged 3 commits into from
Jul 16, 2017

Conversation

balloob
Copy link
Member

@balloob balloob commented Jul 16, 2017

Description:

Rewrite usage of persistent_notification to use the new hass.components.

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing -31 lines 👍

@pvizeli pvizeli merged commit d0275c8 into dev Jul 16, 2017
@balloob balloob deleted the persistent_notification-import branch July 16, 2017 19:52
@balloob balloob mentioned this pull request Jul 29, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
* Rewrite persistent notification creation

* Update components.is_on to use auto loading

* Fix two hass parameters
@home-assistant home-assistant locked and limited conversation to collaborators Oct 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants