Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call update() in constructor #8847

Merged
merged 1 commit into from
Aug 6, 2017
Merged

Do not call update() in constructor #8847

merged 1 commit into from
Aug 6, 2017

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Aug 5, 2017

Description:

  • Do not call update() in constructor
  • Update ordering
  • Update docstrings

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: pocketcasts
    username: !secret pc_username
    password: !secret pc_password

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@mention-bot
Copy link

@fabaff, thanks for your PR! By analyzing the history of the files in this pull request, we identified @molobrakos and @andrey-git to be potential reviewers.

@fabaff fabaff merged commit 569d976 into dev Aug 6, 2017
@fabaff fabaff deleted the update-pocketcasts branch August 6, 2017 08:07
@fabaff fabaff mentioned this pull request Aug 12, 2017
dethpickle pushed a commit to dethpickle/home-assistant that referenced this pull request Aug 18, 2017
@home-assistant home-assistant locked and limited conversation to collaborators Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants