Close stream request once we end up with proxy #9110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@foxel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pvizeli, @balloob and @Danielhiversen to be potential reviewers. |
pvizeli
requested changes
Aug 25, 2017
| @@ -93,6 +93,8 @@ def async_aiohttp_proxy_web(hass, request, web_coro, buffer_size=102400, | |||
| yield from async_aiohttp_proxy_stream(hass, request, req.content, | |||
| req.headers.get(CONTENT_TYPE)) | |||
|
|
|||
| req.close() | |||
There was a problem hiding this comment.
use:
try:
yield from async_aiohttp_proxy...
finally:
req.close()
There was a problem hiding this comment.
Doesn't aiohttp do this automatically? https://github.com/aio-libs/aiohttp/blob/bb646d143cc7bd3b1a614d7c101957b56b11a67f/aiohttp/client_reqrep.py#L500
houndci-bot
reviewed
Aug 26, 2017
| try: | ||
| yield from async_aiohttp_proxy_stream( | ||
| hass, | ||
| request, |
| req.headers.get(CONTENT_TYPE)) | ||
| try: | ||
| yield from async_aiohttp_proxy_stream( | ||
| hass, |
|
Thanks! 🎉 🐬 |
balloob
pushed a commit
that referenced
this pull request
Aug 28, 2017
* Close stream request once we end up with proxy * Update aiohttp_client.py * Update aiohttp_client.py * Removed trailing whitespace
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #9108
This closes connection to mjpeg stream once WEB user ends watching the stream in UI