Allow panels with external URL #9214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
approved these changes
Aug 30, 2017
| if md5 is None: | ||
| with open(path) as fil: | ||
| md5 = hashlib.md5(fil.read().encode('utf-8')).hexdigest() | ||
| if url is None: |
There was a problem hiding this comment.
Can you update the docstring for this method. Also can remove the warning, it's not changing anytime soon.
|
Ok to merge after doc change |
|
I will submit a PR for website/docs update in the morning. |
|
@andrey-git I originally thought that this PR was to allow external URLs in the Can you please re-confirm the intent behind this change? |
|
@dale3h |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Allow panels with external URL
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass