Removing tokens within the app

[towerhand]

In the profile when you click on the "trash can" icon to remove one of the refresh tokens, the confirmation pop up doesn't show up.

HA 0.79.0b2
iOS app 1.2.0 (35)

[mnoorenberghe]

Since that is the web UI within the app this should be moved to https://github.com/home-assistant/home-assistant-polymer/issues

[ghost]

This issue was moved by mnoorenberghe to home-assistant/home-assistant-polymer#1722.

[balloob]

Home Assistant currently uses confirm() to ask user for confirmation.

I am not 100% sure, but that seems like it triggers a signal for iOS?

https://webkitgtk.org/reference/webkit2gtk/1.8.0/WebKitWebView.html#WebKitWebView-script-confirm

(yes, we should build our own confirm)

[robbiet480]

We need to implement webView(_:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:) for this to work.

@balloob Do we call alert() anywhere? If so, I should also implement webView(_:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:)

[balloob]

yeah we do.

[robbiet480]

@balloob Thanks

@blackgold9 we'll need to get this in on 1.5.0

[robbiet480]

Also probably good to implement webView(_:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:)

[balloob]

We use prompt for long lived access tokens.

[towerhand]

Just a quick FYI, this issue wasn’t fixed for the 1.5.0 release.