Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loop when monitoring regions when exceeding maximums #1286

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix infinite loop when monitoring regions when exceeding maximums #1286

merged 2 commits into from
Nov 20, 2020
+33 −0

Commits on Nov 20, 2020

  1. Fix infinite loop when monitoring regions when exceeding maximums 

    At least on iOS 13 and 14, initially monitoring a region causes the system to always fire a did-change-state delegate method for that zone. When users exceed the 20 region threshold, the delegate firing can cause us to bounce back and forth between sets of zones that we want to monitor, and each chain can cause another set of updates to occur. This is especially apparent for users using the iCloud3 integration which creates a multitude of 1m zones.
    @zacwest
    zacwest committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    3a8c333 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into monitor-update

    @zacwest
    zacwest committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    b380cc2 View commit details
    Browse the repository at this point in the history