Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German #21

Merged
merged 14 commits into from Apr 27, 2017
Merged

German #21

merged 14 commits into from Apr 27, 2017

Conversation

TWilb
Copy link
Contributor

@TWilb TWilb commented Apr 18, 2017

Translated everything that could be found in the Localizable.strings file to German.

@homeassistant
Copy link
Contributor

Hello @TWilb,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@mention-bot
Copy link

@TWilb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @robbiet480 and @fearoffish to be potential reviewers.

@homeassistant
Copy link
Contributor

Hi @TWilb,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@robbiet480
Copy link
Member

@TWilb This is great! Little bit of bad news, I just finished translating the rest of the app, so there's another 20 (I think) or so strings for you to update 😅. Hope that's cool, thank you so much for this so far! I plan to get this implemented in 1.0.3 which is going to be released this week.

@TWilb
Copy link
Contributor Author

TWilb commented Apr 19, 2017

@robbiet480 Those aren't bad news - I can translate the missing parts :-) But I am note sure if I will have time to do this today.

@TWilb
Copy link
Contributor Author

TWilb commented Apr 21, 2017

I translated all strings so far - but I cannot test them, since I the build is not running. (see #22)

@robbiet480
Copy link
Member

@TWilb just added a couple more then I think i'm done for at least a few hours :p

"settings.connection_error_notification.title" = "Verbindungsfehler";
"settings.connection_error_notification.message" = "Es ist ein Fehler bei der Verbindung zu Home Assistant aufgetreten. Bitte überprüfe die Einstellungen und speichere sie um erneut zu verbinden. Fehler:\n\n %@";
"settings.certificate_error_notification.title" = "Selbstsigniertes oder ungültiges Zertifikat entdeckt";
"settings.certificate_error_notification.message" = "Ein selbstsigniertes oder ungültiges SSL Zertifikat wurde entdeckt. Solche Zertifikate werden von Home Assistant für iOS nicht unterstützt. Klicke auf den Mehr Info button für weitergehende Informationen.";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zwei Leerzeichen ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schon verschwunden - danke!

Deleted double whitespaces
@robbiet480 robbiet480 merged commit f9bc7ad into home-assistant:master Apr 27, 2017
@robbiet480
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants