Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation icon for actions execution and icon colors based on car interface style #2526

Merged
merged 1 commit into from Jan 17, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Jan 17, 2024

Summary

Screenshots

IMG_2486.mov

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal requested a review from zacwest January 17, 2024 17:02
@bgoncal bgoncal self-assigned this Jan 17, 2024
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (0d1431b) 27.56% compared to head (1ba0686) 27.61%.
Report is 2 commits behind head on master.

Files Patch % Lines
...cle/Templates/Actions/CarPlayActionsTemplate.swift 0.00% 13 Missing ⚠️
...ehicle/Templates/MaterialDesignIcons+CarPlay.swift 0.00% 10 Missing ⚠️
...emplates/Domains/CarPlayDomainsListViewModel.swift 0.00% 5 Missing ⚠️
...le/Templates/Actions/CarPlayActionsViewModel.swift 0.00% 4 Missing ⚠️
...s/Vehicle/Templates/Responses/HAAreaResponse.swift 0.00% 3 Missing ⚠️
Sources/Shared/Domain/Domain.swift 0.00% 2 Missing ⚠️
...le/Templates/Areas/CarPlayAreasZonesTemplate.swift 0.00% 1 Missing ⚠️
...Templates/Domains/CarPlayDomainsListTemplate.swift 0.00% 1 Missing ⚠️
.../Templates/Servers/CarPlayServerListTemplate.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2526      +/-   ##
==========================================
+ Coverage   27.56%   27.61%   +0.04%     
==========================================
  Files         308      308              
  Lines       31401    31394       -7     
==========================================
+ Hits         8655     8668      +13     
+ Misses      22746    22726      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit ca0313d into master Jan 17, 2024
8 checks passed
@bgoncal bgoncal deleted the carplay-actions-confirmation branch January 17, 2024 17:58
@bgoncal bgoncal removed the request for review from zacwest January 17, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant