Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle to make action visible in CarPlay #2529

Merged
merged 3 commits into from Jan 18, 2024
Merged

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Jan 18, 2024

Summary

Screenshots

Screenshot 2024-01-18 at 02 24 31

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal self-assigned this Jan 18, 2024
@bgoncal
Copy link
Member Author

bgoncal commented Jan 18, 2024

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 147 lines in your changes are missing coverage. Please review.

Comparison is base (ca0313d) 27.54% compared to head (4cc7d82) 27.52%.
Report is 3 commits behind head on master.

Files Patch % Lines
...cle/Templates/Actions/CarPlayActionsTemplate.swift 0.00% 34 Missing ⚠️
Sources/App/Settings/ActionConfigurator.swift 0.00% 29 Missing ⚠️
...es/App/Settings/SettingsDetailViewController.swift 0.00% 18 Missing ⚠️
...le/Templates/Actions/CarPlayActionsViewModel.swift 0.00% 18 Missing ⚠️
...ources/App/Notifications/NotificationManager.swift 0.00% 16 Missing ⚠️
Sources/Shared/API/Models/Action.swift 11.11% 16 Missing ⚠️
...hared/Common/Extensions/Realm+Initialization.swift 0.00% 9 Missing ⚠️
Sources/App/Settings/SettingsRootDataSource.swift 0.00% 4 Missing ⚠️
Sources/Shared/API/Responses/MobileAppConfig.swift 0.00% 2 Missing ⚠️
Sources/App/Scenes/SettingsSceneDelegate.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2529      +/-   ##
==========================================
- Coverage   27.54%   27.52%   -0.03%     
==========================================
  Files         308      308              
  Lines       31419    31520     +101     
==========================================
+ Hits         8655     8676      +21     
- Misses      22764    22844      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sources/App/Resources/en.lproj/Localizable.strings Outdated Show resolved Hide resolved
Sources/Shared/API/Models/Action.swift Outdated Show resolved Hide resolved
@bgoncal
Copy link
Member Author

bgoncal commented Jan 18, 2024

Added "Show in Watch"
Screenshot 2024-01-18 at 14 57 59

@bgoncal bgoncal marked this pull request as ready for review January 18, 2024 14:03
@bgoncal bgoncal merged commit 34765e8 into master Jan 18, 2024
8 checks passed
@bgoncal bgoncal deleted the carplay-action-toggle branch January 18, 2024 15:09
@bgoncal
Copy link
Member Author

bgoncal commented Jan 19, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants