Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Localized Strings #2532

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Automatically created by zacwest.

@zacwest zacwest force-pushed the create-pull-request/download_strings branch from 506677a to 8d4416b Compare January 20, 2024 06:03
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (cef9934) 27.54% compared to head (b7a05f4) 27.58%.
Report is 2 commits behind head on master.

Files Patch % Lines
Sources/App/Settings/ActionConfigurator.swift 0.00% 29 Missing ⚠️
Sources/App/Scenes/WindowSizeObserver.swift 36.11% 23 Missing ⚠️
Sources/App/Scenes/WindowScenesManager.swift 65.51% 20 Missing ⚠️
Sources/Shared/API/Models/Action.swift 11.11% 16 Missing ⚠️
...hared/Common/Extensions/Realm+Initialization.swift 0.00% 9 Missing ⚠️
Sources/App/Scenes/WebViewSceneDelegate.swift 50.00% 4 Missing ⚠️
Sources/Shared/API/Responses/MobileAppConfig.swift 0.00% 2 Missing ⚠️
...le/Templates/Actions/CarPlayActionsViewModel.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2532      +/-   ##
==========================================
+ Coverage   27.54%   27.58%   +0.04%     
==========================================
  Files         309      311       +2     
  Lines       31472    31628     +156     
==========================================
+ Hits         8668     8725      +57     
- Misses      22804    22903      +99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacwest zacwest force-pushed the create-pull-request/download_strings branch from 8d4416b to 5358205 Compare January 21, 2024 06:03
@zacwest zacwest force-pushed the create-pull-request/download_strings branch from 5358205 to b7a05f4 Compare January 22, 2024 06:04
@bgoncal bgoncal merged commit 4d63f6d into master Jan 22, 2024
8 checks passed
@bgoncal bgoncal deleted the create-pull-request/download_strings branch January 22, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants