Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix info icon usage in actions #2551

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix info icon usage in actions #2551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 4 additions & 7 deletions Sources/App/Settings/SettingsDetailViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,16 +405,13 @@
let actionsFooter = Current.isCatalyst ?
L10n.SettingsDetails.Actions.footerMac : L10n.SettingsDetails.Actions.footer

let learnAboutActionsButton = ButtonRow {
let learnAboutActionsButton = SettingsButtonRow {

Check warning on line 408 in Sources/App/Settings/SettingsDetailViewController.swift

View check run for this annotation

Codecov / codecov/patch

Sources/App/Settings/SettingsDetailViewController.swift#L408 

Added line #L408 was not covered by tests
$0.title = L10n.SettingsDetails.Actions.Learn.Button.title
$0.tag = "actions_learn_more"
$0.cellStyle = .value1
$0.cellUpdate { cell, _ in
cell.accessoryType = .detailButton
}
$0.onCellSelection { _, _ in
$0.accessoryIcon = .openInNewIcon
$0.onCellSelection { _, row in

Check warning on line 411 in Sources/App/Settings/SettingsDetailViewController.swift

View check run for this annotation

Codecov / codecov/patch

Sources/App/Settings/SettingsDetailViewController.swift#L410-L411 

Added lines #L410 - L411 were not covered by tests
guard let url = URL(string: "https://companion.home-assistant.io/docs/core/actions/") else { return }
UIApplication.shared.open(url)
row.deselect(animated: true)

Check warning on line 414 in Sources/App/Settings/SettingsDetailViewController.swift

View check run for this annotation

Codecov / codecov/patch

Sources/App/Settings/SettingsDetailViewController.swift#L414 

Added line #L414 was not covered by tests
}
}
form +++ learnAboutActionsButton
Expand Down
2 changes: 1 addition & 1 deletion Sources/Shared/Resources/Swiftgen/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ public enum L10n {
}
public enum State {
public enum Loading {
/// Loading...
/// Loading…
public static var title: String { return L10n.tr("Localizable", "carPlay.state.loading.title") }
}
}
Expand Down