Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launch screen logo #2559

Merged
merged 1 commit into from Jan 31, 2024
Merged

Fix launch screen logo #2559

merged 1 commit into from Jan 31, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Jan 31, 2024

Summary

Launchscreen logo asset wasn't in the main target, so it wasn't being displayed

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (ccddeb8) 27.52% compared to head (a8dc014) 27.49%.
Report is 4 commits behind head on master.

Files Patch % Lines
Sources/App/Settings/ActionConfigurator.swift 0.00% 34 Missing ⚠️
Sources/App/WebView/WebViewController.swift 0.00% 28 Missing ⚠️
...es/App/Settings/SettingsDetailViewController.swift 0.00% 13 Missing ⚠️
Sources/App/Settings/Eureka/YamlSection.swift 0.00% 5 Missing ⚠️
...ources/Shared/API/WebSocket/WebSocketMessage.swift 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2559      +/-   ##
==========================================
- Coverage   27.52%   27.49%   -0.03%     
==========================================
  Files         311      311              
  Lines       31653    31706      +53     
==========================================
+ Hits         8712     8718       +6     
- Misses      22941    22988      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgoncal bgoncal merged commit 3ebd1e6 into master Jan 31, 2024
8 checks passed
@bgoncal bgoncal deleted the fix-launch-screen branch January 31, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launch screen iOS Does not work anymore since 2023.7
1 participant