Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QR code scanner #2576

Merged
merged 12 commits into from Feb 19, 2024
Merged

Add QR code scanner #2576

merged 12 commits into from Feb 19, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Feb 8, 2024

Summary

Add QR code scanner that can be triggered from HA and receive result response

Screenshots

RPReplay_Final1707399075.MP4

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal
Copy link
Member Author

bgoncal commented Feb 8, 2024

Copy link

emerge-tools bot commented Feb 8, 2024

1 build increased size

Name Version Download Change Install Change Approval
Home Assistant
io.robbie.HomeAssistant
2024.2 (2024.3060) 44.0 MB ⬆️ 31.8 kB (0.07%) 92.5 MB ⬆️ 80.4 kB (0.09%) N/A

Home Assistant 2024.2 (2024.3060)
io.robbie.HomeAssistant

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 80.4 kB (0.09%)
Total download size change: ⬆️ 31.8 kB (0.07%)

Largest size changes

Item Install Size Change
DYLD.Fixups ⬆️ 5.0 kB
DYLD.String Table ⬆️ 4.5 kB
📝 HomeAssistant.BarcodeScannerView.topInformation ⬆️ 3.8 kB
📝 HomeAssistant.BarcodeScannerView.cameraSquare ⬆️ 3.3 kB
📝 HomeAssistant.BarcodeScannerView.body ⬆️ 3.2 kB

Image of diff


🛸 Powered by Emerge Tools

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 508 lines in your changes are missing coverage. Please review.

Comparison is base (4cc467a) 27.54% compared to head (2279a48) 27.04%.

Files Patch % Lines
...pp/QRCodeScanner/Camera/BarcodeScannerCamera.swift 0.00% 282 Missing ⚠️
Sources/App/QRCodeScanner/BarcodeScannerView.swift 0.00% 106 Missing ⚠️
Sources/App/WebView/WebViewController.swift 0.00% 44 Missing ⚠️
...es/App/QRCodeScanner/BarcodeScannerViewModel.swift 0.00% 31 Missing ⚠️
...QRCodeScanner/Camera/BarcodeScannerDataModel.swift 0.00% 24 Missing ⚠️
...RCodeScanner/Camera/BarcodeScannerCameraView.swift 0.00% 19 Missing ⚠️
...ources/Shared/API/WebSocket/WebSocketMessage.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2576      +/-   ##
==========================================
- Coverage   27.54%   27.04%   -0.51%     
==========================================
  Files         311      316       +5     
  Lines       31699    32219     +520     
==========================================
- Hits         8733     8714      -19     
- Misses      22966    23505     +539     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@home-assistant home-assistant bot marked this pull request as draft February 9, 2024 04:26
@home-assistant
Copy link

home-assistant bot commented Feb 9, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@bgoncal bgoncal marked this pull request as ready for review February 12, 2024 13:28
@bgoncal bgoncal merged commit 02a8457 into master Feb 19, 2024
8 checks passed
@bgoncal bgoncal deleted the qrcodescanner branch February 19, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants