Fix Pedometer being deallocated during query #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This codepath needs to maintain a strong reference to the CMPedometer, or else it deallocates which tears down the Promise prematurely, resulting in the sensors not being created/sent.
zacwest
commented
Jun 20, 2020
| @@ -189,11 +189,12 @@ public class Environment { | |||
|
|
|||
| /// Wrapper around CMPedometeer | |||
| public struct Pedometer { | |||
| private let underlyingPedometer = CMPedometer() | |||
There was a problem hiding this comment.
this is exactly the same as the CMMotionActivityManager above, not sure why i didn't do it here
robbiet480
approved these changes
Jun 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codepath needs to maintain a strong reference to the CMPedometer, or else it deallocates which tears down the Promise prematurely, resulting in the sensors not being created/sent.