Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supervisor_ingress support #73

Merged
merged 3 commits into from Jun 1, 2021
Merged

Add supervisor_ingress support #73

merged 3 commits into from Jun 1, 2021

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented May 4, 2021

redirect.json Outdated Show resolved Hide resolved
redirect.json Outdated
@@ -233,6 +233,19 @@
"description": "show your Supervisor system information",
"introduced": "supervisor-2021.02.12"
},
{
"redirect": "supervisor_ingress",
"name": "Supervisor: Ingress",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs add-on in it, to make clear it is for a specific add-on?

redirect.json Outdated
{
"redirect": "supervisor_ingress",
"name": "Supervisor: Ingress",
"badge": "Ingress",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe just this one, Add-on: Ingress

redirect.json Outdated
Comment on lines 4 to 5
"name": "Add-on: Ingress",
"badge": "Ingress",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed the name now, and not the badge, intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you wanted both? 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes 😄

@ludeeus ludeeus merged commit 6c45e08 into main Jun 1, 2021
@ludeeus ludeeus deleted the supervisor_ingress branch June 1, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants