Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fsfreeze support on OVA #2787

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix fsfreeze support on OVA #2787

merged 1 commit into from
Oct 3, 2023

Conversation

agners
Copy link
Member

@agners agners commented Oct 3, 2023

Pass the script argument properly to make sure the script gets actually called from the QEMU guest agent.

@agners
Fix fsfreeze freeze support
3e347c9 
Pass the script argument properly to make sure the script gets actually
called from the QEMU guest agent.
@agners agners added the board/ova Open Virtual Appliance (Virtual Machine) label Oct 3, 2023
@agners agners changed the title Fix fsfreeze freeze support Fix fsfreeze support on OVA Oct 3, 2023
sairon
sairon approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick test shows it indeed makes a difference, but it's quite confusing it fails (or does nothing) only when the fs-freeze hook should be actually called 🤦

@agners agners merged commit 2cbaaf9 into home-assistant:dev Oct 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairon sairon sairon approved these changes

Assignees
No one assigned
Labels
board/ova Open Virtual Appliance (Virtual Machine) cla-signed hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@agners @sairon