Start HA CLI interactively and with a tty allocated #3238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use -i (--interactive) and -t (--tty) to start the HA CLI interactively. This is required by some commands like the new device wipe command added with home-assistant/cli#464.
mdegat01
approved these changes
Mar 11, 2024
sairon
approved these changes
Mar 12, 2024
sairon
added a commit
that referenced
this pull request
Mar 12, 2024
The test was missing --no-progress flag, which only manifested after merging #3238 - causing the CLI to run in an interactive pseudotty.
sairon
added a commit
that referenced
this pull request
Mar 12, 2024
The test was missing --no-progress flag, which only manifested after merging #3238 - causing the CLI to run in an interactive pseudotty.
sairon
pushed a commit
that referenced
this pull request
Mar 12, 2024
Use -i (--interactive) and -t (--tty) to start the HA CLI interactively. This is required by some commands like the new device wipe command added with home-assistant/cli#464. (cherry picked from commit fe1978f)
sairon
added a commit
that referenced
this pull request
Mar 12, 2024
sairon
added a commit
that referenced
this pull request
Apr 8, 2024
Flags for running HA CLI commands in an interactive shell added in #3238 cause the command to fail if the process is not running in a terminal. This is needed for example for the fsfreeze hook, otherwise the command fails, as seen in this trace when the hook is executed: ----------- + '[' thaw '=' freeze ] + '[' thaw '=' thaw ] + echo 'File system thaw requested, thawing Home Assistant' File system thaw requested, thawing Home Assistant + ha backups thaw the input device is not a TTY ------------ However, for example on Proxmox this message is not logged anywhere and the hook just fails silently (i.e. it doesn't cause the backup to fail). Fixes #3251
sairon
added a commit
that referenced
this pull request
Apr 8, 2024
Flags for running HA CLI commands in an interactive shell added in #3238 cause the command to fail if the process is not running in a terminal. This is needed for example for the fsfreeze hook, otherwise the command fails, as seen in this trace when the hook is executed: ----------- + '[' thaw '=' freeze ] + '[' thaw '=' thaw ] + echo 'File system thaw requested, thawing Home Assistant' File system thaw requested, thawing Home Assistant + ha backups thaw the input device is not a TTY ------------ However, for example on Proxmox this message is not logged anywhere and the hook just fails silently (i.e. it doesn't cause the backup to fail). Fixes #3251
sairon
added a commit
that referenced
this pull request
Apr 8, 2024
Flags for running HA CLI commands in an interactive shell added in #3238 cause the command to fail if the process is not running in a terminal. This is needed for example for the fsfreeze hook, otherwise the command fails, as seen in this trace when the hook is executed: ----------- + '[' thaw '=' freeze ] + '[' thaw '=' thaw ] + echo 'File system thaw requested, thawing Home Assistant' File system thaw requested, thawing Home Assistant + ha backups thaw the input device is not a TTY ------------ However, for example on Proxmox this message is not logged anywhere and the hook just fails silently (i.e. it doesn't cause the backup to fail). Fixes #3251
sairon
added a commit
that referenced
this pull request
Apr 8, 2024
* Only run HA CLI interactively if stdout is a terminal Flags for running HA CLI commands in an interactive shell added in #3238 cause the command to fail if the process is not running in a terminal. This is needed for example for the fsfreeze hook, otherwise the command fails, as seen in this trace when the hook is executed: ----------- + '[' thaw '=' freeze ] + '[' thaw '=' thaw ] + echo 'File system thaw requested, thawing Home Assistant' File system thaw requested, thawing Home Assistant + ha backups thaw the input device is not a TTY ------------ However, for example on Proxmox this message is not logged anywhere and the hook just fails silently (i.e. it doesn't cause the backup to fail). Fixes #3251 * Use -i also when not running in a terminal
sairon
added a commit
that referenced
this pull request
Apr 8, 2024
* Only run HA CLI interactively if stdout is a terminal Flags for running HA CLI commands in an interactive shell added in #3238 cause the command to fail if the process is not running in a terminal. This is needed for example for the fsfreeze hook, otherwise the command fails, as seen in this trace when the hook is executed: ----------- + '[' thaw '=' freeze ] + '[' thaw '=' thaw ] + echo 'File system thaw requested, thawing Home Assistant' File system thaw requested, thawing Home Assistant + ha backups thaw the input device is not a TTY ------------ However, for example on Proxmox this message is not logged anywhere and the hook just fails silently (i.e. it doesn't cause the backup to fail). Fixes #3251 * Use -i also when not running in a terminal (cherry picked from commit 78d281f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use -i (--interactive) and -t (--tty) to start the HA CLI interactively. This is required by some commands like the new device wipe command added with home-assistant/cli#464.