New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Buildroot to 2024.02 #3241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated to version 2.10.x compatible with libblockdev v3 * Rebased patches to new codebase * Autoreconf patch is not needed anymore * libblockdev-nvme is now hard dependency of udisks daemon
After the Go update, build fails with the following error on mod vendor: GOPROXY list is not the empty string, but contains no entries Turns out this step is not having the environment variables set, use those used for download to fix it.
* buildroot 3f950a1aee...a1b2d12f32 (1): > package/nfs-utils: only install fsidd binary and unit file with enabled nfsd
sairon
force-pushed
the
buildroot-2024.02
branch
from
March 12, 2024 16:38
c94ee9d
to
54aeb25
Compare
Use distribution package, as it's what's used in Buidlroot's Gitlab CI Docker image at buildroot/support/docker/Dockefile.
agners
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. There are some package checks failing because upstream tags are missing. From my point of view we can also disable that particular check, if possible.
It was introduced in latest BR - disable it for now and re-enable for HAOS in a later separate PR.
agners
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Buildroot to latest LTS release. Builds fine, basic testing also found no issues. In general some library changes pulled in some more dependencies and increased the bloat a little (like udisks or nfs-utils) but it's still bearable. For details of changes required for the update see description of individual commits.