Fix Supervisor container name reference in hassos-supervisor service #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jun 5, 2020
| @@ -11,9 +11,9 @@ StartLimitBurst=5 | |||
| Type=simple | |||
| Restart=always | |||
| RestartSec=5s | |||
| ExecStartPre=-/usr/bin/docker stop hassos_supervisor | |||
| ExecStartPre=-/usr/bin/docker stop hassio_supervisor | |||
| ExecStart=/usr/sbin/hassos-supervisor | |||
There was a problem hiding this comment.
I can see how this error has sneaked in, probably because of the name here.
For a future PR, should the docker logic exists in the systemd file or should we add a /usr/sbin/hassos-supervisor --stop to keep all logic in 1 file?
There was a problem hiding this comment.
I think having the docker stop right here in ExecStop is a valid case.
The ExecStartPre could be handled by the hassos-supervisor as it does a whole lot of checks already.
There was a problem hiding this comment.
Yeah, it would make sense. It would be nice to have some libs like bashio for OS to share some functions.
pvizeli
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The systemd service for the hassos-supervisor service used incorrect references to the Supervisor container. This PR addresses that.