Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach TTY for hassio_cli wrapper to make spinner work #332

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

marceldev89
Copy link
Contributor

No description provided.

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @marceldev89

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marceldev89 👍

../Frenck

@frenck frenck merged commit 21a9d0b into home-assistant:main Oct 23, 2023
2 checks passed
@marceldev89
Copy link
Contributor Author

@frenck thanks for the quick merge! :)

However, the change breaks (bash) completion because -t changes the line endings to CRLF. Submitted another PR to fix this at #334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants