Fix watchdog & scheduler #1757
Merged
Fix watchdog & scheduler #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supervisor/misc/scheduler.py
Outdated
| if not self.suspend: | ||
| self.loop.create_task(data[CALL]()) | ||
| if self.sys_core.state == CoreStates.RUNNING: | ||
| self.sys_loop.create_task(data[CALL]()) |
There was a problem hiding this comment.
Is the context unspecific here, so we need to specify what loop to use when creating the task, ie use loop.create_task instead of asyncio.create_task?
There was a problem hiding this comment.
It's sys_create_task. asyncio.create_task has more overhead which we can avoid anyway with our structure they we created before with python 3.4
There was a problem hiding this comment.
Ok. In the long run I think it's wise to try to move to the recommended higher level APIs. This is a trend in asyncio.
There was a problem hiding this comment.
Sure, I wait for executor/callback pool to have a high-level API and we can migrate once all to it. maybe with Python 4 - anyway there are ~53 bigger tasks on ClickUp
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
MartinHjelmare
approved these changes
May 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.