Docs string and exception message improvements #1767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvizeli
approved these changes
Jun 2, 2020
| @@ -137,10 +137,10 @@ def _extract_addon( | |||
|
|
|||
| addon = self.sys_addons.get(addon_slug) | |||
| if not addon: | |||
| raise APIError("Addon does not exist") | |||
| raise APIError(f"Addon {addon_slug} does not exist", addon_slug) | |||
There was a problem hiding this comment.
The second argument is a mistake, right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements to docstrings and error messages. Added the add-on slug to some exceptions thrown, so it becomes more clear which add-on causes it.