Handle new API / Frontend early boot #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
bramkragten
reviewed
Jun 2, 2020
| status = resp.status | ||
| _LOGGER.warning("Home Assistant API config mismatch: %s", status) | ||
| data = await resp.json() | ||
| if data.get("state", "RUNNING") == "RUNNING": |
There was a problem hiding this comment.
Why would we wait on running for the rollback check? The frontend would be up already the user would be able to configure or fix whatever problem there could be, so why not just check if the frontend is up?
There was a problem hiding this comment.
Let's merge P2 and we can start to play with that. You can after P2 start to add new integration or remove integration etc while HA is startup? We can later split up the check for block startup and API proxy 👍
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid also log flooding because we restart Core.
90% of the code is for P2 and the other 10% for P1. Since we need anyway touch the code and change the logic. The P1 adds the 503 for API which makes this PR a lot simpler.