Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uvloop #2176

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Remove uvloop #2176

merged 1 commit into from
Oct 26, 2020

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Oct 26, 2020

Proposed change

aiohttp 1.7.1 with native file send did not work anymore with uvloop. We don't really need uvloop, so let's remove it. It's a nice eventloop if you need to process a lot of connections, but for us, we have no downside to use the new c asyncio extension.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli merged commit 8e57cd2 into main Oct 26, 2020
@pvizeli pvizeli deleted the ditch-uvloop branch October 26, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants