Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default for add-on startup config #2419

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Set a default for add-on startup config #2419

merged 1 commit into from
Jan 11, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 11, 2021

Proposed change

Set a default for the add-on startup configuration, making the configuration parameter optional.

The default is set to application. Looking at the add-ons, most use service, however, I think application is a sane and safe default. Add-ons that have a more specific startup requirement can still use this option of course.

This PR allows cleaning up add-on configurations a bit more and is backward compatible.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@frenck frenck marked this pull request as ready for review January 11, 2021 10:37
@pvizeli pvizeli merged commit 5a00336 into main Jan 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the frenck-2021-0016 branch January 11, 2021 11:10
@ludeeus ludeeus added the refactor A code change that neither fixes a bug nor adds a feature label Jan 11, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants