Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default for add-on options and schema config #2421

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 11, 2021

Proposed change

It is always nice if an add-on doesn't need any options (and thus might not have a schema).

This PR adds a default empty dictionaries to the schema and options configuration parameters of an add-on configuration, mainly for cleaner add-on configurations.

For a future improvement, it would be nice if we could expose if the add-on has options (and thus a schema) and hide the config from the UI based on that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@frenck frenck added the refactor A code change that neither fixes a bug nor adds a feature label Jan 11, 2021
@frenck frenck marked this pull request as ready for review January 11, 2021 11:25
@ludeeus ludeeus merged commit ec6852a into main Jan 11, 2021
@ludeeus ludeeus deleted the frenck-2021-0018 branch January 11, 2021 11:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants