Next generation hardware handling #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvizeli
force-pushed
the
next-hardware
branch
from
6da6974
to
6d3d5a8
Compare
Co-authored-by: Franck Nijhof <git@frenck.dev>
|
This would be also requested by Deconz @manup |
agners
reviewed
Jan 28, 2021
| @@ -284,7 +308,7 @@ def volumes(self) -> Dict[str, Dict[str, str]]: | |||
| # Init other hardware mappings | |||
|
|
|||
| # GPIO support | |||
| if self.addon.with_gpio and self.sys_hardware.support_gpio: | |||
| if self.addon.with_gpio and self.sys_hardware.helper.support_gpio: | |||
There was a problem hiding this comment.
The new libgpiod uses /dev/gpiochip* devices. Do we support that? I guess we could just add that as well if an addon wants GPIO access. See e.g. https://embeddedbits.org/new-linux-kernel-gpio-user-space-interface/
There was a problem hiding this comment.
Done by cgroup rules. We need only to know if we can apply it. But yeah, this function would be gone after I know the sys endpoint and can do it like for audio.
Co-authored-by: Stefan Agner <stefan@agner.ch>
Co-authored-by: Stefan Agner <stefan@agner.ch>
Co-authored-by: Stefan Agner <stefan@agner.ch>
…ervisor into next-hardware
ludeeus
reviewed
Jan 28, 2021
Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
ludeeus
approved these changes
Jan 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Rewrite the complete udev handling inside Supervisor. Now we only based on the host udev events and all hardware interactions are based on these events/lists.
It also removes the udev handling needs from the add-on. This is now a complete handle over the supervisor. The add-on config has a new option type
device. This will be lookup and control by Supervisor and make most of the device hot&plug able. Based on device types or USB IDs, we generate a complete list for UI selection. We work internally also with the udev ID to make sure devices get correct mapped, also if the user does not use device-by-id selectors.These changes aim a full working device handling to the user, almost like he do run Core.
Type of change
Additional information
Checklist
black --fast supervisor tests)If API endpoints of add-on configuration are added/changed: