Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with awesomeversion and representation #2443

Merged
merged 1 commit into from Jan 17, 2021
Merged

Fix issues with awesomeversion and representation #2443

merged 1 commit into from Jan 17, 2021

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jan 17, 2021 •
edited

Proposed change

Follow up of: ludeeus/awesomeversion#28

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli requested a review from ludeeus January 17, 2021 15:32
@pvizeli pvizeli merged commit f73e277 into main Jan 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-awesomeversion-string branch January 17, 2021 15:39
@pvizeli pvizeli added the bugfix A bug fix label Jan 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ludeeus ludeeus ludeeus approved these changes

Assignees
No one assigned
Labels
bugfix A bug fix cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't install add-on when version key includes alpha-characters
3 participants
@pvizeli @ludeeus @homeassistant