Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fixups with Job condition checks #2451

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Improve fixups with Job condition checks #2451

merged 1 commit into from
Jan 21, 2021

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Jan 19, 2021 •
edited

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli added the refactor A code change that neither fixes a bug nor adds a feature label Jan 19, 2021
@pvizeli pvizeli requested a review from frenck January 20, 2021 09:22
@pvizeli pvizeli merged commit dccfffd into main Jan 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the improve-fixups-jobs branch January 21, 2021 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pvizeli @frenck @homeassistant