Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API endpoint for add-on for his own config #2515

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Feb 4, 2021

Proposed change

It's more something for the future. I want that bashio get/cache the config from an endpoint instead to deal with a written file to a bind mount.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli added the new-feature A new feature label Feb 4, 2021
@pvizeli pvizeli requested review from frenck and ludeeus and removed request for frenck and ludeeus February 4, 2021 14:03
@pvizeli pvizeli merged commit e0c3fd8 into main Feb 4, 2021
@pvizeli pvizeli deleted the api-addon-endpoint-config branch February 4, 2021 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants