Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for static port in Watchdog add-on configuration #2589

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Feb 19, 2021

Proposed change

This PR add support for a static port configuration to the Watchdog URL add-on configuration.
Currently, it requires a defined port (while this should not be needed in most cases).

Fixes: hassio-addons/addon-zwave-js-ui#49

21-02-19 14:01:41 WARNING (MainThread) [supervisor.store.data] Can't read /data/addons/git/40817795/zwavejs2mqtt/config.json: does not match regular expression for dictionary value @ data['watchdog']. Got 'http://[HOST]:8099/health/zwave'

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli added refactor A code change that neither fixes a bug nor adds a feature new-feature A new feature and removed refactor A code change that neither fixes a bug nor adds a feature labels Feb 19, 2021
@frenck frenck merged commit e60d858 into main Feb 19, 2021
@frenck frenck deleted the frenck-2021-0725 branch February 19, 2021 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants