Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show add-on with bad config in log #2601

Merged
merged 4 commits into from
Feb 22, 2021
Merged

Show add-on with bad config in log #2601

merged 4 commits into from
Feb 22, 2021

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Feb 22, 2021

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@ludeeus ludeeus added the refactor A code change that neither fixes a bug nor adds a feature label Feb 22, 2021
pvizeli
pvizeli approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merge after lint issue is fix 👍

@ludeeus ludeeus merged commit 15544ae into main Feb 22, 2021
@ludeeus ludeeus deleted the addon-option-validate-log branch February 22, 2021 12:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
cla-signed refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addon Log doesn't show which addon is at fault
3 participants
@ludeeus @pvizeli @homeassistant