Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send event when add-on changes state #2608

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Send event when add-on changes state #2608

merged 2 commits into from
Feb 23, 2021

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Feb 23, 2021

Proposed change

Send an event when an add-on changes a state.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@ludeeus ludeeus added the new-feature A new feature label Feb 23, 2021
@MartinHjelmare
Copy link
Member

Looks good!

@pvizeli pvizeli merged commit 90d8832 into main Feb 23, 2021
@pvizeli pvizeli deleted the addon.state branch February 23, 2021 14:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants