Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for pwned secrets to resolution center #2614

Merged
merged 15 commits into from
Feb 25, 2021
Merged

Add check for pwned secrets to resolution center #2614

merged 15 commits into from
Feb 25, 2021

Conversation

pvizeli
Copy link
Member

@pvizeli pvizeli commented Feb 24, 2021

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints of add-on configuration are added/changed:

@pvizeli pvizeli added the new-feature A new feature label Feb 24, 2021
@pvizeli pvizeli marked this pull request as ready for review February 24, 2021 15:18
@pvizeli
Copy link
Member Author

pvizeli commented Feb 24, 2021

More info page: home-assistant/home-assistant.io#16730

@ludeeus ludeeus mentioned this pull request Feb 24, 2021
12 tasks
@ludeeus
Copy link
Member

ludeeus commented Feb 24, 2021

Checking this should have a Job with the INTERNET_SYSTEM JobCondition

@ludeeus
Copy link
Member

ludeeus commented Feb 24, 2021

So we need to adjust this https://www.home-assistant.io/privacy/?

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet stuff Pascal!

supervisor/resolution/checks/base.py Outdated Show resolved Hide resolved
supervisor/resolution/notify.py Outdated Show resolved Hide resolved
supervisor/utils/pwned.py Outdated Show resolved Hide resolved
supervisor/resolution/checks/base.py Outdated Show resolved Hide resolved
@frenck
Copy link
Member

frenck commented Feb 24, 2021

So we need to adjust this home-assistant.io/privacy?

Not sure, as the password is never sent and not collected either.

https://www.troyhunt.com/ive-just-launched-pwned-passwords-version-2/#cloudflareprivacyandkanonymity

pvizeli and others added 5 commits February 25, 2021 09:07
Co-authored-by: Franck Nijhof <git@frenck.dev>
Co-authored-by: Franck Nijhof <git@frenck.dev>
Co-authored-by: Franck Nijhof <git@frenck.dev>
@pvizeli pvizeli merged commit 85d527b into main Feb 25, 2021
@pvizeli pvizeli deleted the pwned branch February 25, 2021 08:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants