Real-time fixes #2630
Merged
Real-time fixes #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix detection of CPU bandwidth allocation (CONFIG_RT_GROUP_SCHED) option by checking the correct file location.
Set a soft limit of real-time priority 90 and hard limit of 99. The maximum is 99, to avoid add-ons using such a high priority without second thought set the soft limit to 90. This allows a process to higher the limit to 99, if really required. Also set max locked memory to 128MB. Locking memory from getting paged out is often used for the real-time process/thread to avoid delays due to swapping/pageing in. Ideally a real-time process should only do the real-time job, hence not need too much memory.
|
@jens-maus not sure what priority your add-on will use, but I'd recommend to use something lower than 90. it will still be the highest priority in the system (aside from some special kernel threads). |
pvizeli
added
the
refactor
pvizeli
approved these changes
Feb 25, 2021
pvizeli
approved these changes
Feb 25, 2021
jens-maus
reviewed
Feb 25, 2021
| @@ -265,8 +265,12 @@ def ulimits(self) -> Optional[List[docker.types.Ulimit]]: | |||
| limits: List[docker.types.Ulimit] = [] | |||
|
|
|||
| # Need schedule functions | |||
| if self.addon.with_realtime and self.sys_docker.info.support_cpu_realtime: | |||
There was a problem hiding this comment.
@agners Did you remove the self.sys_docker.info.support_cpu_realtime on purpose? Because this seems to skip the check if the system (kernel) has CONFIG_RT_GROUP_SCHED or not.
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix detection of CPU bandwidth allocation (CONFIG_RT_GROUP_SCHED) option
by checking the correct file location.
Set a soft limit of real-time priority 90 and hard limit of 99. The
maximum is 99, to avoid add-ons using such a high priority without
second thought set the soft limit to 90. This allows a process to higher
the limit to 99, if really required.
Also set max locked memory to 128MB. Locking memory from getting paged
out is often used for the real-time process/thread to avoid delays due
to swapping/pageing in. Ideally a real-time process should only do the
real-time job, hence not need too much memory.
Proposed change
Type of change
Additional information
Checklist
black --fast supervisor tests)If API endpoints of add-on configuration are added/changed: